Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: attach when add runtime module #7935

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix: attach when add runtime module #7935

merged 1 commit into from
Sep 20, 2024

Conversation

LingyuCoder
Copy link
Collaborator

Summary

Just attach chunk, compilation and chunkGraph to runtime module when added

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Sep 20, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 20, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit ef370dd
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66ed27c8552df80008d36730

@LingyuCoder LingyuCoder changed the title fix: attach before runtime module generate fix: attach when add runtime module Sep 20, 2024
@LingyuCoder LingyuCoder merged commit 10f0c34 into main Sep 20, 2024
35 checks passed
@LingyuCoder LingyuCoder deleted the fix/runtime-module-attach branch September 20, 2024 07:58
JSerFeng pushed a commit that referenced this pull request Sep 29, 2024
@LingyuCoder @JSerFeng
fix: attach when add runtime module (#7935)
e93c663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardfist hardfist hardfist approved these changes

Assignees

@LingyuCoder LingyuCoder

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LingyuCoder @hardfist